-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/fix jenkins go version #473
Conversation
Jenkins failed to run the regression test. I have encountered this error before locally and resolved it at the time by upgrading my local Go version to 1.16+. This change - pegs the Go version to 1.18.3 - adds download and a naive install step to the CI computer. Date: 2022-06-07 14:53:49-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-06-07 15:04:10-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-06-07 15:04:29-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-06-07 15:05:07-07:00 Signed-off-by: meows <[email protected]>
This reverts commit 4903b60.
Date: 2022-06-07 15:11:23-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-06-07 15:13:59-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-06-07 15:16:47-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-06-07 15:20:18-07:00 Signed-off-by: meows <[email protected]>
solution: why mv when we can cp Date: 2022-06-07 15:25:42-07:00 Signed-off-by: meows <[email protected]>
Date: 2022-06-07 15:34:24-07:00 Signed-off-by: meows <[email protected]>
@@ -22,6 +22,11 @@ pipeline { | |||
stage('Kotti') { | |||
agent { label "aws-slave-m5-xlarge" } | |||
steps { | |||
sh "curl -L -O https://go.dev/dl/go1.18.3.linux-amd64.tar.gz" | |||
sh "sudo rm -rf /usr/bin/go && sudo rm -rf /usr/local/go && sudo tar -C /usr/local -xzf go1.18.3.linux-amd64.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/usr/bin/go
is the default Go installation. /usr/local/go
is the dir where we extract the downloaded Go artifacts to. Even though its normally redundant to remove the latter, it is useful when the instance gets reused and straggling PATH or artifacts otherwise may exist. Jenkins maintains the EC2 instances for a short period following a run to save on restart-startup cost/time, so rapid pushes can be run on the same "machine."
The following stanzas specify the expected Go executable artifacts precisely to provide better information for the reader.
Also note that this branch name matches the pattern |
Latest, passing Jenkins run: https://ci.etccore.in/blue/organizations/jenkins/core-geth-regression/detail/core-geth-regression/242/pipeline/ |
LGTM |
The Jenkins pipeline which handles regression tests started failing. I believe this is because of out-of-date Go versions on the EC2 instances. The failure is here: https://ci.etccore.in/blue/organizations/jenkins/core-geth-regression/detail/core-geth-regression/233/pipeline.
Current pipeline version:
I've encountered a similar error locally before and I was able to resolve it by upgrading my local Go version, so that's what I'm trying here.