Ensure that the EIP1559DenominatorCanyon is set if the canyon override is set #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the ways to opt-in to canyon is to use the
--override.canyon
flag. However, currently this does not set theEIP1559DenominatorCanyon
chain configuration value, which causes panics in the EIP-1559 code due to divide-by-zero errors.This PR introduces a quick fix to set the
EIP1559DenominatorCanyon
to250
if it's0
. We can follow up with a longer term fix for better default hardfork configuration for chains that are not in the superchain registry.Tests
Tested on our sepolia devnet.
Additional context
panic: