Action tests for Isthmus withdrawal root addition #12925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2024
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
5 times, most recently
from
20229d0 to
d55e52e
Compare
vdamle
force-pushed
the
vd/action-test-isthmus
branch
2 times, most recently
from
f484cbb to
296d948
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## vd/l2-withdrawals-root #12925 +/- ##
===========================================================
- Coverage 79.11% 43.02% -36.09%
===========================================================
Files 166 781 +615
Lines 9359 69777 +60418
Branches 760 0 -760
===========================================================
+ Hits 7404 30025 +22621
- Misses 1701 37162 +35461
- Partials 254 2590 +2336
Flags with carried forward coverage won't be shown. Click here to find out more. |
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
from
d55e52e to
144e2e1
Compare
vdamle
force-pushed
the
vd/action-test-isthmus
branch
from
296d948 to
e502243
Compare
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
from
144e2e1 to
d07938e
Compare
vdamle
force-pushed
the
vd/action-test-isthmus
branch
from
e502243 to
e95c2bd
Compare
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
from
26c779e to
11620de
Compare
vdamle
force-pushed
the
vd/action-test-isthmus
branch
from
e95c2bd to
5ba13e6
Compare
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
from
11620de to
3419f1f
Compare
vdamle
requested review from
maurelian,
ajsutton and
mslipper
and removed request for
a team
added 3 commits
January 2, 2025 23:05
* test all combinations - with/without withdrawal transaction before, at and after isthmus
* test when isthmus is active at genesis * test fields before canyon activation and before isthmus activation (after canyon) * withdrawal root at isthmus with/without a l2 withdrawal transaction * withdrawal root after isthmus with/without a l2 withdrawal transaction * copy pre-allocs for isthmus from holocene
vdamle
force-pushed
the
vd/action-test-isthmus
branch
from
5ba13e6 to
59b4836
Compare
|
Closing in favor of #13962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action tests for changes in: #12848
ref: #12044