e2e/system: add test for the batcher recovering from an L2 chain rewind #13386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13386 +/- ##
===========================================
- Coverage 47.36% 47.18% -0.18%
===========================================
Files 939 939
Lines 78469 78469
Branches 796 796
===========================================
- Hits 37168 37029 -139
- Misses 38526 38665 +139
Partials 2775 2775
Flags with carried forward coverage won't be shown. Click here to find out more. |
geoknee
commented
Dec 13, 2024
Comment on lines
+36
to
+37
| // Wait for the intervention to take effect | ||
| time.Sleep(time.Second * 5) |
There was a problem hiding this comment.
I don't love this wait, here -- appreciate any suggestions on how to make this more event-driven.
geoknee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13355 .
I just found #5168, which underlines what a perennial issue batcher testing is.
This PR does not try to be a comprehensive approach to that general problem, but just adds a very simple test which would have caught a recent batcher bug, and mirrors some manual kurtosis testing we have been doing #13192.
An extension would be to rewind the l1 chain and check the batcher can recover from that.