Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node,op-program: source rollup-configs from superchain-registry #6581

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented Aug 3, 2023

Description

To make OP-Stack chain configurations available across OP-Stack client implementations, we are experimenting with a "superchain-registry": one place that hosts all superchain configurations, which can then be embedded into the software for convenience & OP-Stack wide rollout of config changes.

This depends on the op-geth superchain-registry integration

This will enable op-node users to pick any chain from the registered Superchains as chain to run the op-node with: no more manual rollup.json required. This simplifies the configuration-management: network upgrades can be specified in superchain-wide configuration.

rollup.json might change, but we plan to keep supporting manual configuration, for testing / bootstrap / customization purposes, the OP-Stack is open after all.

The op-program is not in production yet, and thus gets full access to the superchain-registry data.
The op-node is in production, and while the superchain-registry is experimental, does not expose the full selection of chains.

To access a configuration from the superchain-registry, add --beta.extra-networks to your selection of op-node flags, and then use --network to select a chain like normal.

The default-network configurations are tested to match the expected configurations, to ensure the op-node does not behave differently, even with the superchain-registry dependency.

Metadata

Fix CLI-4207

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

⚠️ No Changeset found

Latest commit: a5015db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Aug 3, 2023
@mergify mergify bot removed the conflict label Aug 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2023

Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added conflict S-conflict Status: A conflict is present labels Aug 14, 2023
@refcell refcell removed the conflict label Aug 16, 2023
@mergify mergify bot added A-op-node Area: op-node A-op-program Area: op-program A-op-challenger Area: op-challenger and removed S-conflict Status: A conflict is present labels Aug 17, 2023
@mergify mergify bot added the A-op-e2e Area: op-e2e label Aug 17, 2023
@protolambda protolambda changed the title op-node,op-program: source rollup-configs from superchain-registry [Work in progress] op-node,op-program: source rollup-configs from superchain-registry Aug 17, 2023
@protolambda protolambda force-pushed the superchain-config branch 2 times, most recently from c4b208a to 3fa5c8c Compare August 18, 2023 20:05
@protolambda protolambda marked this pull request as ready for review August 18, 2023 20:13
@protolambda protolambda requested review from a team and trianglesphere as code owners August 18, 2023 20:13
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chains test does give me high confidence that this isn't breaking anything & I verified that the chain configs in the test are the same as the chain configs on develop.

I'm having a hard time reviewing this because so much is pulled in from the superchain-registry repo & there is a lot of magic in terms of how stuff is expected to be rather than simple data.

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Aug 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mslipper mslipper merged commit 875bac3 into develop Aug 21, 2023
@mslipper mslipper deleted the superchain-config branch August 21, 2023 23:44
@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-challenger Area: op-challenger A-op-e2e Area: op-e2e A-op-node Area: op-node A-op-program Area: op-program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants