-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node,op-program: source rollup-configs from superchain-registry #6581
Conversation
|
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review. |
dfdbd27
to
a5015db
Compare
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review. |
a5015db
to
ec2bd03
Compare
ec2bd03
to
f3d5067
Compare
c4b208a
to
3fa5c8c
Compare
3fa5c8c
to
b1aa179
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chains test does give me high confidence that this isn't breaking anything & I verified that the chain configs in the test are the same as the chain configs on develop.
I'm having a hard time reviewing this because so much is pulled in from the superchain-registry repo & there is a lot of magic in terms of how stuff is expected to be rather than simple data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
To make OP-Stack chain configurations available across OP-Stack client implementations, we are experimenting with a "superchain-registry": one place that hosts all superchain configurations, which can then be embedded into the software for convenience & OP-Stack wide rollout of config changes.
This depends on the op-geth superchain-registry integration
This will enable op-node users to pick any chain from the registered Superchains as chain to run the op-node with: no more manual
rollup.json
required. This simplifies the configuration-management: network upgrades can be specified in superchain-wide configuration.rollup.json
might change, but we plan to keep supporting manual configuration, for testing / bootstrap / customization purposes, the OP-Stack is open after all.The
op-program
is not in production yet, and thus gets full access to the superchain-registry data.The
op-node
is in production, and while the superchain-registry is experimental, does not expose the full selection of chains.To access a configuration from the superchain-registry, add
--beta.extra-networks
to your selection ofop-node
flags, and then use--network
to select a chain like normal.The default-network configurations are tested to match the expected configurations, to ensure the op-node does not behave differently, even with the superchain-registry dependency.
Metadata
Fix CLI-4207