Skip to content

Update EIP-658: fix grammar #17255

Update EIP-658: fix grammar

Update EIP-658: fix grammar #17255

Triggered via pull request October 2, 2024 14:44
Status Cancelled
Total duration 1m 41s
Artifacts 1

ci.yml

on: pull_request
Save PR Number
2s
Save PR Number
HTMLProofer
1m 14s
HTMLProofer
Link Check
20s
Link Check
CodeSpell
10s
CodeSpell
EIP Walidator
4s
EIP Walidator
Markdown Linter
5s
Markdown Linter
Fit to window
Zoom out
Zoom in

Annotations

16 errors and 6 warnings
proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`): EIPS/eip-658.md#L16
error[markdown-re-eip-dash]: proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`) --> EIPS/eip-658.md | 16 | With the introduction of the REVERT opcode in EIP140, it is no longer possible for users to assume that a transaction failed if it consumed all gas. As a result, there is no clear mechanism for callers to determine whether a transaction succeeded and the state changes contained in it were applied. | = info: the pattern in question: `(?i)eip[\s]*[0-9]+` = help: see https://ethereum.github.io/eipw/markdown-re-eip-dash/
proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`): EIPS/eip-658.md#L20
error[markdown-re-eip-dash]: proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`) --> EIPS/eip-658.md | 20 | Instead, we propose to replace the intermediate state root, already obsoleted by EIP98, with the return status (1 for success, 0 for failure). This both allows callers to determine success status, and remedies the previous omission of return data from the receipt. | = info: the pattern in question: `(?i)eip[\s]*[0-9]+`
body is missing section(s): `Security Considerations`: EIPS/eip-658.md#L11
error[markdown-req-section]: body is missing section(s): `Security Considerations` --> EIPS/eip-658.md | | = help: must be at the second level (`## Heading`) = help: see https://ethereum.github.io/eipw/markdown-req-section/
preamble header `author` must contain at least one GitHub username: EIPS/eip-658.md#L4
error[preamble-author]: preamble header `author` must contain at least one GitHub username --> EIPS/eip-658.md | 4 | author: Nick Johnson <[email protected]> | = help: see https://ethereum.github.io/eipw/preamble-author/
preamble header `title` value is too long (max 44): EIPS/eip-658.md#L3
error[preamble-len-title]: preamble header `title` value is too long (max 44) --> EIPS/eip-658.md:3:7 | 3 | title: Embedding transaction status code in receipts | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ too long | = help: see https://ethereum.github.io/eipw/preamble-len-title/
preamble header `type` is out of order: EIPS/eip-658.md#L5
error[preamble-order]: preamble header `type` is out of order --> EIPS/eip-658.md | 5 | type: Standards Track | = help: `type` should come after `status` = help: see https://ethereum.github.io/eipw/preamble-order/
preamble is missing header(s): `description`, `discussions-to`: EIPS/eip-658.md#L1
error[preamble-req]: preamble is missing header(s): `description`, `discussions-to` --> EIPS/eip-658.md | | = help: see https://ethereum.github.io/eipw/preamble-req/
EIP Walidator
validation found errors :(
Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Abstract"]: EIPS/eip-658.md#L12
EIPS/eip-658.md:12 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Abstract"]
Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Motivation"]: EIPS/eip-658.md#L15
EIPS/eip-658.md:15 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Motivation"]
Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Specification"]: EIPS/eip-658.md#L22
EIPS/eip-658.md:22 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Specification"]
Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Rationale"]: EIPS/eip-658.md#L25
EIPS/eip-658.md:25 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Rationale"]
Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Copyright"]: EIPS/eip-658.md#L28
EIPS/eip-658.md:28 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Copyright"]
Markdown Linter
Failed with exit code: 1
HTMLProofer
Canceling since a higher priority waiting request for 'Continuous Integration-8923' exists
HTMLProofer
The operation was canceled.
Save PR Number
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@65d862660abb392b8c4a3d1195a2108db131dd05. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
EIP Walidator
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Markdown Linter
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f, DavidAnson/markdownlint-cli2-action@f5cf187ef11bd3a68a127321b794aa252ff23019. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
CodeSpell
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Link Check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "pr_number". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
pr_number Expired
87 Bytes