Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-6123: Add hardhat to project #6646

Closed
wants to merge 10 commits into from
Closed

Update EIP-6123: Add hardhat to project #6646

wants to merge 10 commits into from

Conversation

Kourouta
Copy link
Contributor

@Kourouta Kourouta commented Mar 8, 2023 •
edited by github-actions bot
Loading

  • Add hardhat
  • Tidy up unit tests
  • Update README.md

@Kourouta Kourouta requested a review from eth-bot as a code owner March 8, 2023 10:08
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 8, 2023 •
edited
Loading

🛑 Auto merge failed. Please see logs for more details, and report this issue at the eip-review-bot repository.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Mar 8, 2023
@Kourouta Kourouta changed the title Feature 0200 Add hardhat to EIP-6123 Mar 8, 2023
@Kourouta
Copy link
Contributor Author

@eth-bot rerun

Pandapip1
Pandapip1 previously requested changes Mar 17, 2023
View reviewed changes
@Kourouta Kourouta requested a review from Pandapip1 March 22, 2023 08:05
@Kourouta
Copy link
Contributor Author

@Pandapip1 is there still need for action on my part?

@Pandapip1 Pandapip1 mentioned this pull request Mar 27, 2023
Open
@Kourouta Kourouta changed the title Add hardhat to EIP-6123 Update EIP-6123: Add hardhat to project Mar 28, 2023
@Kourouta
Copy link
Contributor Author

Kourouta commented Apr 3, 2023

@Pandapip1 @pekola @cfries what's hindering this pull request from being merged?

@lightclient lightclient dismissed Pandapip1’s stale review April 14, 2023 16:47

requested change was made by author

@Kourouta
Copy link
Contributor Author

@eth-bot rerun

@Kourouta Kourouta requested a review from lightclient April 27, 2023 06:43
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Sep 11, 2023
@SamWilsn
Copy link
Contributor

I don't feel confident resolving this merge conflict. If you are still interested in making this change, please feel free to re-open (or re-submit) this pull request.

@SamWilsn SamWilsn closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitrichDot MitrichDot MitrichDot approved these changes

@Scamreno Scamreno Scamreno approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

@Pandapip1 Pandapip1 Awaiting requested review from Pandapip1

@lightclient lightclient Awaiting requested review from lightclient

Assignees
No one assigned
Labels
e-consensus Waiting on editor consensus w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kourouta @eth-bot @SamWilsn @lightclient @Pandapip1 @MitrichDot @Scamreno