Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Registries and Adapters for Smart Accounts #7484

Merged
merged 19 commits into from
Oct 18, 2023

Conversation

kopy-kat
Copy link
Contributor

@kopy-kat kopy-kat commented Aug 14, 2023

This proposal standardises the interface and functionality of Module Registries, allowing modular smart contract accounts to verify the security of modules using a Registry Adapter. It also provides a reference implementation of a Singleton Module Registry.

@kopy-kat kopy-kat requested a review from eth-bot as a code owner August 14, 2023 16:46
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Aug 14, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 14, 2023

File EIPS/eip-7484.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Aug 14, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Aug 14, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Aug 14, 2023
@eth-bot eth-bot changed the title Add EIP: Registry Adapters for Smart Accounts Add EIP: Module Registries and Adapters for Smart Accounts Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

The commit 368b641 (as a parent of 50ef126) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 4, 2023
@eth-bot eth-bot changed the title Add EIP: Module Registries and Adapters for Smart Accounts Add EIP: Registries and Adapters for Smart Accounts Oct 4, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 4, 2023
@lightclient lightclient merged commit 15299e6 into ethereum:master Oct 18, 2023
streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
* Add EIP: Registry Adapters for Smart Accounts

* Add eip field and update discussions-to

* change filenames

* added sequence diagram to check function

* added spec that check function MUST revert

* added explanation why this ERC favours uint48 timestamps

* deleted AttestationRequest and SchemaRecord as its out of scope for this registry

* new file: JPG of check sequence diagram

* refactor check and verify in specification and implement remaining feedback

* standardise capitalisation and remove unused asset

* changing spec language as discussed

* spec to disable "unrevocation"

* changes in spec terms as dicsussed

* change specifications for check and verify

* correct revokedAt permanent definition

* implement feedback on motivation, change structure, iterate on reference implementation

* fix: title length

---------

Co-authored-by: zeroknots <[email protected]>
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
* Add EIP: Registry Adapters for Smart Accounts

* Add eip field and update discussions-to

* change filenames

* added sequence diagram to check function

* added spec that check function MUST revert

* added explanation why this ERC favours uint48 timestamps

* deleted AttestationRequest and SchemaRecord as its out of scope for this registry

* new file: JPG of check sequence diagram

* refactor check and verify in specification and implement remaining feedback

* standardise capitalisation and remove unused asset

* changing spec language as discussed

* spec to disable "unrevocation"

* changes in spec terms as dicsussed

* change specifications for check and verify

* correct revokedAt permanent definition

* implement feedback on motivation, change structure, iterate on reference implementation

* fix: title length

---------

Co-authored-by: zeroknots <[email protected]>
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
* Add EIP: Registry Adapters for Smart Accounts

* Add eip field and update discussions-to

* change filenames

* added sequence diagram to check function

* added spec that check function MUST revert

* added explanation why this ERC favours uint48 timestamps

* deleted AttestationRequest and SchemaRecord as its out of scope for this registry

* new file: JPG of check sequence diagram

* refactor check and verify in specification and implement remaining feedback

* standardise capitalisation and remove unused asset

* changing spec language as discussed

* spec to disable "unrevocation"

* changes in spec terms as dicsussed

* change specifications for check and verify

* correct revokedAt permanent definition

* implement feedback on motivation, change structure, iterate on reference implementation

* fix: title length

---------

Co-authored-by: zeroknots <[email protected]>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
* Add EIP: Registry Adapters for Smart Accounts

* Add eip field and update discussions-to

* change filenames

* added sequence diagram to check function

* added spec that check function MUST revert

* added explanation why this ERC favours uint48 timestamps

* deleted AttestationRequest and SchemaRecord as its out of scope for this registry

* new file: JPG of check sequence diagram

* refactor check and verify in specification and implement remaining feedback

* standardise capitalisation and remove unused asset

* changing spec language as discussed

* spec to disable "unrevocation"

* changes in spec terms as dicsussed

* change specifications for check and verify

* correct revokedAt permanent definition

* implement feedback on motivation, change structure, iterate on reference implementation

* fix: title length

---------

Co-authored-by: zeroknots <[email protected]>
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
* Add EIP: Registry Adapters for Smart Accounts

* Add eip field and update discussions-to

* change filenames

* added sequence diagram to check function

* added spec that check function MUST revert

* added explanation why this ERC favours uint48 timestamps

* deleted AttestationRequest and SchemaRecord as its out of scope for this registry

* new file: JPG of check sequence diagram

* refactor check and verify in specification and implement remaining feedback

* standardise capitalisation and remove unused asset

* changing spec language as discussed

* spec to disable "unrevocation"

* changes in spec terms as dicsussed

* change specifications for check and verify

* correct revokedAt permanent definition

* implement feedback on motivation, change structure, iterate on reference implementation

* fix: title length

---------

Co-authored-by: zeroknots <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants