Update EIP-6551: Preventing circular lock situation with initialize

[Abhijaypaliwal]

Description

This pull request adds the initialize function for EIP-6551 as described in the guidelines. The initialize function can be called by the owner after ownership change to set the currOwner and prevOwner variables. Additionally, the unlockCircularLock function is introduced to handle situations of circular lock, allowing the previous owner to unlock it.

Changes

Added Functions

• initialize(uint256 tokenId) external : Initializes the currOwner and prevOwner variables after ownership change.

• unlockCircularLock(uint256 tokenId) external : Allows the previous owner to unlock the circular lock situation by calling this function.

Modifications

• Modified the ERC6551Account contract to include the new variables currOwner and prevOwner.

Tests

• Added comprehensive tests to cover the new functionalities, including the initialize and unlockCircularLock functions.

Motivation

This enhancement is in line with the objectives of EIP-6551 and provides additional functionalities for handling ownership transitions and circular lock scenarios.

Usage

1. After ownership change, the new owner can call the initialize function to set the current owner (currOwner) and previous owner (prevOwner) variables.

2. In cases of circular lock, the previous owner can use the unlockCircularLock function to release the lock.

Issues

The initialize function could only be used to change previousOwner. and this value could only be used for account recovery. however if new owner of Token transfer it to another owner without initialization, the previousOwner is not changed, hence the recovery can be done by third last owner and he can call it without any restriction, which could be malicious.

Checklist

• Code follows the EIP-6551 guidelines.
• Added appropriate tests for the new functionalities.
• Documentation has been updated to reflect the changes.

[eth-bot]

File EIPS/eip-6551.md

Requires 1 more reviewers from @DruzyDowns, @huynhr, @jaydenwindle, @jfschwarz, @jhweintraub, @k06a, @RobAnon, @sullivph) [email protected], auryn macmillan (@auryn-macmillan, @wwhchung, @ZumZoom

[jaydenwindle]

Thanks for the PR @Abhijaypaliwal! This is an interesting concept but seems very opinionated and may not be the best fit for including in the EIP reference implementation. Instead I'd recommend opening up a PR against the erc6551/reference repo with this functionality as an example in the examples folder. We can work together to polish it and then consider including it in the EIP document.

[Abhijaypaliwal]

sure @jaydenwindle i would do the same and we would work together for adding this functionality in near future. I am very much looking forward for this functionality!

[SamWilsn]

I'm closing based on the recommendation from #7525 (comment). Please feel free to re-open if you're still interested in pursuing!