Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7508: Move to Review #7737

Closed

Conversation

ThunderDeliverer
Copy link
Contributor

As the EIP is ready to be peer-reviewed by the community, we propose it be moved to the Review stage.

As the EIP is ready to be peer reviewed by the community, we propose it
be moved to the Review stage.
@github-actions github-actions bot added c-status Changes a proposal's status s-review This EIP is in Review t-erc labels Sep 19, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 19, 2023

File EIPS/eip-7508.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-review Waiting on editor to review label Sep 19, 2023
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you include a requires: 712 for the presigned attribute?

@ThunderDeliverer
Copy link
Contributor Author

Should you include a requires: 712 for the presigned attribute?

Yes, this was needed. Thank you for catching it @SamWilsn !

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants