Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC: ERC-20 Transfer Reference Extension #399

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Add ERC: ERC-20 Transfer Reference Extension #399

merged 9 commits into from
Oct 29, 2024

Conversation

radeksvarz
Copy link
Contributor

No description provided.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 26, 2024 •
edited
Loading

✅ All reviewers have approved.

@github-actions github-actions bot added the w-ci label Apr 26, 2024
@eip-review-bot eip-review-bot changed the title added ERC proposal - ERC20 payment reference extension Add ERC: ERC20 Payment reference extension Apr 26, 2024
abcoathup
abcoathup reviewed Apr 26, 2024
View reviewed changes
abcoathup
abcoathup reviewed Apr 26, 2024
View reviewed changes
@github-actions github-actions bot added w-ci and removed w-ci labels Apr 27, 2024
SamWilsn
SamWilsn reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix all the errors generated by the linter: https://github.com/ethereum/ERCs/actions/runs/8858664958/job/24327583845

@radeksvarz
Copy link
Contributor Author

You'll need to fix all the errors generated by the linter: https://github.com/ethereum/ERCs/actions/runs/8858664958/job/24327583845

@SamWilsn Thx for letting me know. I will fix those. Would you be so kind and help initiate the discussion on related ethereum magicians among wallets (mainly Metamask, Rabby) and explorers (Etherscan, Blockscout)?

@SamWilsn
Copy link
Contributor

@radeksvarz we'd be happy to have you on the next AllWalletDevs call! You can find the details and discord server here: https://allwallet.dev/

@eip-review-bot eip-review-bot changed the title Add ERC: ERC20 Payment reference extension Add ERC: ERC-20 Payment Reference Extension Jun 12, 2024
@github-actions github-actions bot added w-ci and removed w-ci labels Jun 12, 2024
@github-actions github-actions bot removed the w-ci label Jun 12, 2024
SamWilsn
SamWilsn requested changes Jun 13, 2024
View reviewed changes
@radeksvarz
Updated erc-7699.md
c1fbddd 
based on discussions and conclusions on magiciains
@eip-review-bot eip-review-bot changed the title Add ERC: ERC-20 Payment Reference Extension Add ERC: ERC-20 Transfer Reference Extension Oct 1, 2024
@github-actions github-actions bot added the w-ci label Oct 1, 2024
@radeksvarz
Copy link
Contributor Author

I added the section ## Privacy Considerations (reflecting the Web3Privacy Now initiative). Is that a problem?

@radeksvarz radeksvarz requested a review from SamWilsn October 1, 2024 14:07
@radeksvarz
Copy link
Contributor Author

I added the section ## Privacy Considerations (reflecting the Web3Privacy Now initiative). Is that a problem?

@SamWilsn I fixed the license, can you please react on the section issue?

@github-actions GitHub Actions
Copy link

The commit 79ccc9b (as a parent of a942587) contains errors.
Please inspect the Run Summary for details.

@radeksvarz
Copy link
Contributor Author

@abcoathup , @fhar28 pls help

I added the section ## Privacy Considerations (reflecting the Web3Privacy Now initiative). Is that a problem?

@github-actions github-actions bot removed the w-ci label Oct 16, 2024
@radeksvarz radeksvarz mentioned this pull request Oct 23, 2024
Closed
58 tasks
SamWilsn
SamWilsn approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to fix these at some point while you're in draft.

@eip-review-bot eip-review-bot enabled auto-merge (squash) October 29, 2024 14:43
eip-review-bot
eip-review-bot approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 3d411a0 into ethereum:master Oct 29, 2024
10 checks passed
radeksvarz added a commit to radeksvarz/ERCs that referenced this pull request Nov 12, 2024
@radeksvarz
Update erc-7699.md - suggested minor fixes
ee2836e 
as suggested by Sam during finalization of initial PR ethereum#399
@radeksvarz radeksvarz mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@SamWilsn SamWilsn SamWilsn approved these changes

@Gemk83 Gemk83 Gemk83 approved these changes

@Hawthorne001 Hawthorne001 Hawthorne001 approved these changes

@eip-review-bot eip-review-bot eip-review-bot approved these changes

Assignees
No one assigned
Labels
c-new e-consensus e-review s-draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@radeksvarz @eip-review-bot @SamWilsn @abcoathup @Gemk83 @Hawthorne001