This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Update Aleth tools to return error codes #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfalicious
force-pushed
the
return-error-codes
branch
from
625a46a to
a7c4ab1
Compare
|
Need to fix bad cherry pick |
Prior to these changes the various Aleth tools (e.g. aleth, aleth-bootnode, aleth-vm) would return -1 on error. These changes define a new error enum (AlethError) with error codes for the various error conditions and update the various tools to return these codes.
halfalicious
force-pushed
the
return-error-codes
branch
from
a7c4ab1 to
73fd11d
Compare
halfalicious
requested review from
gumb0 and
chfast
and removed request for
gumb0
Fixed |
|
I'd like to merge this change before the aleth-bootnode one (#5485) so I can update aleth-bootnode to return the appropriate error code for the new error that it detects (network not started). |
gumb0
approved these changes
Feb 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these changes the various Aleth tools (e.g. aleth, aleth-bootnode, aleth-vm) would return -1 on error. These changes define a new error enum (AlethError) with error codes for the various error conditions and update the various tools to return these codes.