This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Implement EIP-2046 Reduced gas cost for static calls made to precompiles in LegacyVM #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
staticcall-precompile-cost
branch
from
6e05686 to
f2d070e
Compare
Codecov Report
@@ Coverage Diff @@
## master #5699 +/- ##
==========================================
+ Coverage 63.85% 63.92% +0.06%
==========================================
Files 359 359
Lines 30609 30667 +58
Branches 3406 3410 +4
==========================================
+ Hits 19545 19603 +58
Misses 9838 9838
Partials 1226 1226 |
|
This is also not accepted yet, so shouldn't be merged. |
gumb0
force-pushed
the
staticcall-precompile-cost
branch
from
56e933d to
fffd80e
Compare
|
This is rebased and ready for review. |
gumb0
force-pushed
the
staticcall-precompile-cost
branch
from
fffd80e to
13e0660
Compare
|
Rebased once again and updated changelog. |
halfalicious
reviewed
Sep 1, 2019
|
|
||
| void testCallHasCorrectCost() | ||
| { | ||
| // let r := call(10000, 0x4, 0, 0, 0, 0, 0) |
There was a problem hiding this comment.
(Nit) can we document these args e.g.:
call(10000 /* gas /, 0x4 / address /, 0 / value */, ...)
Makes the test code a little more readable 😀
halfalicious
approved these changes
Sep 1, 2019
|
@halfalicious Thanks for the review, this shouldn't be merged yet, as this EIP was not accepted for Istanbul, but probably will go into the next hard fork. I will either put it into Experimental fork or create a new EVMSchedule for Berlin, next hard fork. |
gumb0
force-pushed
the
staticcall-precompile-cost
branch
from
95e11aa to
6308d72
Compare
|
Rebased. |
gumb0
force-pushed
the
staticcall-precompile-cost
branch
from
6308d72 to
2f1464b
Compare
|
Moved to Berlin fork. |
gumb0
force-pushed
the
staticcall-precompile-cost
branch
2 times, most recently
from
daf150f to
e2d46b3
Compare
Reduced gas cost for static calls made to precompiles.
gumb0
force-pushed
the
staticcall-precompile-cost
branch
from
e2d46b3 to
b92624b
Compare
gumb0
force-pushed
the
staticcall-precompile-cost
branch
from
b92624b to
df6a681
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-2046
Note that it puts repricing behind account versioning, i.e. reduced cost will be in effect only in contracts deployed with external transaction after Istanbul fork.If it's decided that it should be in effect for version 0, we'll need to introduce anotherEVMSchedule("between" currentConstantinopleFixScheduleandIstanbulSchedule)Account versioning is disabled in Istanbul.