Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eip-review-bot detects a status change with a new EIP #354

Closed
minkyn opened this issue Dec 1, 2023 · 3 comments · Fixed by #355
Closed

eip-review-bot detects a status change with a new EIP #354

minkyn opened this issue Dec 1, 2023 · 3 comments · Fixed by #355
Labels
🐛 bug Something isn't working 🔥 P1 Bad; needs resolution sooner rather than later

Comments

@minkyn
Copy link

minkyn commented Dec 1, 2023

Pull Request

ethereum/ERCs#91

What happened?

All other preconditions have been met for this PR, including human approval, CI checks, but the bot still won't trigger merging automatically.

image

Relevant log output

No response
@minkyn
Copy link
Author

minkyn commented Dec 4, 2023

Ping @SamWilsn

@Pandapip1
Copy link
Member

The bug appears to be that status changes are being requested for new EIPs with the category being nothing.

@Pandapip1 Pandapip1 transferred this issue from ethereum/ERCs Dec 4, 2023
@Pandapip1 Pandapip1 added 🐛 bug Something isn't working 🔥 P1 Bad; needs resolution sooner rather than later labels Dec 4, 2023
@Pandapip1
Copy link
Member

Okay, it appears that this is to do with creating a new EIP that contains assets. I believe I have a fix.

@Pandapip1 Pandapip1 changed the title eip-review-bot won't approve the PR to trigger merging eip-review-bot thinks that a status change occurs when a new EIP with assets is added Dec 4, 2023
@Pandapip1 Pandapip1 changed the title eip-review-bot thinks that a status change occurs when a new EIP with assets is added eip-review-bot thinks that a status change with new EIP Dec 4, 2023
@Pandapip1 Pandapip1 changed the title eip-review-bot thinks that a status change with new EIP eip-review-bot detects a status change with a new EIP Dec 4, 2023
@Pandapip1 Pandapip1 mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🔥 P1 Bad; needs resolution sooner rather than later
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Performance optimization and bug fix for asset files ethereum/eip-review-bot
2 participants
@minkyn @Pandapip1