-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Cross-Contract Hierarchical NFT #91
Conversation
✅ All reviewers have approved. |
@xinbenlv Please take another look. Previous comments include adding a set method and supplementing security considerations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for draft status
The commit 403db67 (as a parent of b36b022) contains errors. |
How do I request to get approval from @eip-review-bot please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retrigger merging
@SamWilsn Sam, can you please help take a look why the bot didn't automatically approve it when all other checks have been satisfied? |
@eth-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Reopen this ongoing draft from the old PR in repo
EIPs
with all comments addressed.