Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Cross-Contract Hierarchical NFT #91

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Add ERC: Cross-Contract Hierarchical NFT #91

merged 8 commits into from
Dec 5, 2023

Conversation

minkyn
Copy link
Contributor

@minkyn minkyn commented Nov 6, 2023

Reopen this ongoing draft from the old PR in repo EIPs with all comments addressed.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Nov 6, 2023

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add ERC-7510: Cross-Contract Hierarchical NFT Add ERC: Cross-Contract Hierarchical NFT Nov 6, 2023
@minkyn
Copy link
Contributor Author

minkyn commented Nov 8, 2023

@xinbenlv Please take another look. Previous comments include adding a set method and supplementing security considerations.

Copy link
Collaborator

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for draft status

@minkyn
Copy link
Contributor Author

minkyn commented Nov 21, 2023

@SamWilsn Please help with the merge due to this issue

Copy link

The commit 403db67 (as a parent of b36b022) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Nov 29, 2023
@minkyn
Copy link
Contributor Author

minkyn commented Nov 29, 2023

How do I request to get approval from @eip-review-bot please?

@minkyn minkyn marked this pull request as draft November 30, 2023 05:57
@minkyn minkyn marked this pull request as ready for review November 30, 2023 05:58
Copy link
Collaborator

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrigger merging

@minkyn
Copy link
Contributor Author

minkyn commented Nov 30, 2023

@SamWilsn Sam, can you please help take a look why the bot didn't automatically approve it when all other checks have been satisfied?

@Pandapip1
Copy link
Member

@eth-bot rerun

@eip-review-bot eip-review-bot enabled auto-merge (squash) December 5, 2023 02:57
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit fedd464 into ethereum:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants