Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light: make LightChain receiver names consistent #18997

Conversation

Matthalp-zz
Copy link
Contributor

@Matthalp-zz Matthalp-zz commented Feb 5, 2019

Currently half the files use lc and the other half use self for the receiver variable name. This adopts lc as it is is more idiomatic golang.

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@karalabe karalabe added this to the 1.9.0 milestone Feb 6, 2019
@Matthalp-zz Matthalp-zz force-pushed the make-lightchain-receiver-name-consistent branch from 69bb6b1 to 10204b2 Compare February 6, 2019 14:55
@Matthalp-zz Matthalp-zz force-pushed the make-lightchain-receiver-name-consistent branch from 10204b2 to 2c289ce Compare February 6, 2019 22:07
@Matthalp-zz Matthalp-zz force-pushed the make-lightchain-receiver-name-consistent branch from 2c289ce to 77359e1 Compare February 7, 2019 01:37
@karalabe karalabe merged commit 6f714ed into ethereum:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants