cmd/devp2p: tweak DNS TTLs #20801
Merged
cmd/devp2p: tweak DNS TTLs #20801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Mar 24, 2020
cmd/devp2p/dnscmd.go
Outdated
| rootTTL = 1 | ||
| treeNodeTTL = 2147483647 | ||
| rootTTL = 30 * 60 // 30 min | ||
| treeNodeTTL = 2 * 7 * 24 * 60 * 60 // 2 weeks |
There was a problem hiding this comment.
Any reason to decrease this? AFAIK this thing is immutable.
There was a problem hiding this comment.
I just thought the previous one was ridiculously high. Most DNS caches won't keep things forever anyway.
There was a problem hiding this comment.
It was the highest that Cloudflare allowed. I know they won't keep it forever, but the current code will just cause everyone to rerequest everything every 2 weeks.
15 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
* cmd/devp2p: tweak DNS TTLs * cmd/devp2p: bump treeNodeTTL to four weeks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the TTL on tree root records to enable some caching.
It also decreases the TTL on the leaves to a saner value.