eth/tracers: refactor block context in test runner #29450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
reviewed
Apr 5, 2024
s1na
reviewed
Apr 5, 2024
|
Hey @jsvisa do you still want this in? Its a bit tiny of a refactor, but if you rebase it on master, we could get it merged |
Sorry for the longlong delay, I'll rebase it later today |
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
|
@s1na @MariusVanDerWijden PTAL |
s1na
reviewed
Feb 18, 2025
| @@ -11,8 +11,7 @@ | |||
| "number": "1", | |||
| "stateRoot": "0xd2ebe0a7f3572ffe3e5b4c78147376d3fca767f236e4dd23f9151acfec7cb0d1", | |||
| "timestamp": "1699617692", | |||
| "withdrawals": [], | |||
| "withdrawalsRoot": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", | |||
| "totalDifficulty": "0", | |||
There was a problem hiding this comment.
Total difficulty is removed now from API. I think this line (and in the diffs above) can be removed.
Signed-off-by: jsvisa <[email protected]>
s1na
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some simple adjustment for the trace testcase:
withdrawals{Root},genesis.baseFeePerGasinmakeTest.js;tracerConfiginmaketest.jsis not null;tracerTestEnvstruct;