accounts/abi/bind: change to use hash as parameter #30079
Conversation
|
Oh I like this change a lot. The problem is that this changes a much used API. I would be fine with breaking it, but I know @fjl doesn't like us breaking downstream users. |
In fact, users prefer to use hash. Users all know this function, but because they have to pass in tx, they have to choose to implement this function themselves. |
I often make wheels like this repeatedly. I think this change is very necessary for users. Thanks for your understanding! |
|
So, since we ourselves use this in all abigen stuff, we can't break the API, sorry. But we can introduce a new method for waiting on a hash (or deploying a hash). |
|
@mask-pp I pushed a commit on top that adds |
It's great, thanks for your commit. |
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
This change adds methods which makes it possible for to wait for a transaction with a specific hash when deploying contracts during abi bind interaction. --------- Co-authored-by: Marius van der Wijden <[email protected]>
Users prefer to use a hash instead of a tx point.