Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi: support unpacking solidity errors #30738

Merged

Conversation

darrenvechain
Copy link
Contributor

@darrenvechain darrenvechain commented Nov 6, 2024

This PR adds the error fragments to func (abi ABI) getArguments which allows typed decoding of errors

@darrenvechain darrenvechain changed the title abi: unpack error into interface accounts/abi: unpack error into interface Nov 6, 2024
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@fjl fjl changed the title accounts/abi: unpack error into interface accounts/abi: support unpacking errors Dec 10, 2024
@holiman holiman added this to the 1.14.13 milestone Dec 10, 2024
@fjl fjl changed the title accounts/abi: support unpacking errors accounts/abi: support unpacking solidity errors Dec 10, 2024
@fjl fjl merged commit 330190e into ethereum:master Dec 10, 2024
3 checks passed
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 11, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 14, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 16, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 17, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 23, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
@fjl fjl modified the milestones: 1.14.13, 1.15.0 Jan 23, 2025
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025
This PR adds the error fragments to `func (abi ABI) getArguments` which
allows typed decoding of errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants