Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: add lint step #31068

Merged
merged 4 commits into from
Jan 28, 2025
Merged

.github: add lint step #31068

merged 4 commits into from
Jan 28, 2025

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 23, 2025

appveyor too slow

check_generate seems to take longer than others. Will check it in future.

@s1na
Copy link
Contributor Author

s1na commented Jan 23, 2025

@MariusVanDerWijden I noticed you explicitly disabled the cache while setting up golang. Does it have something to do with running the jobs self-hosted? I enabled the cache for when build/ci.go downloads linting dependency tools and now wondering.

@@ -8,6 +8,30 @@ on:
workflow_dispatch:

jobs:
lint:
name: Lint
runs-on: self-hosted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't run on self-hosted, it's going to be discontinued

@fjl fjl merged commit 3fcbb67 into ethereum:master Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants