Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/fuzzers/bls12381: fix error message in fuzzCrossG2Add #31113

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

0xkazak
Copy link
Contributor

@0xkazak 0xkazak commented Feb 2, 2025

Description:
I noticed a typo in the error message within the fuzzCrossG2Add function. The panic message incorrectly references "G1 point addition mismatch" when it should be "G2 point addition mismatch," as the function deals with G2 points.

This doesn't affect functionality but could cause confusion during debugging. I've updated the message to reflect the correct curve.

Here's the fix:

panic("G2 point addition mismatch blst / geth ")

Thanks!

@MariusVanDerWijden
Copy link
Member

Looks like you fixed it in the wrong place, you fixed it in fuzzCrossG1Add

@0xkazak
Copy link
Contributor Author

0xkazak commented Feb 3, 2025

Looks like you fixed it in the wrong place, you fixed it in fuzzCrossG1Add

MariusVanDerWijden, fixed.

@MariusVanDerWijden MariusVanDerWijden changed the title chore: fix incorrect error message in fuzzCrossG2Add function tests/fuzzers/bls12381: fix error message in fuzzCrossG2Add Feb 4, 2025
@MariusVanDerWijden MariusVanDerWijden merged commit e26dd77 into ethereum:master Feb 4, 2025
2 checks passed
@MariusVanDerWijden MariusVanDerWijden added this to the 1.15.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants