eth: report error from setupDiscovery at startup #31233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this while trying to debug a discv5 thing. I tried to disable DNS discovery using `--discovery.dns=false`, which doesn't work. Annoyingly, geth started anyway and discarded the error silently. I eventually found my mistake, but it took way longer than it should have. Also including a small change to the error message for invalid DNS URLs here. The user actually needs to see the URL to make sense of the error.
fjl
requested review from
zsfelfoldi,
holiman and
rjl493456442
as code owners
| @@ -368,7 +368,9 @@ func (s *Ethereum) Protocols() []p2p.Protocol { | |||
| // Start implements node.Lifecycle, starting all internal goroutines needed by the | |||
| // Ethereum protocol implementation. | |||
| func (s *Ethereum) Start() error { | |||
| s.setupDiscovery() | |||
| if err := s.setupDiscovery(); err != nil { | |||
There was a problem hiding this comment.
Notably, Geth will stop immediately if an error occurs in the discovery setup, e.g. the provided DNS URL is invalid.
I think it should be the correct behavior. Any invalid DNS url should be detected as early as possible, instead of launching node silently.
rjl493456442
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this while trying to debug a discv5 thing. I tried to disable DNS discovery using
--discovery.dns=false, which doesn't work. Annoyingly, geth started anyway and discarded the error silently. I eventually found my mistake, but it took way longer than it should have.Also including a small change to the error message for invalid DNS URLs here. The user actually needs to see the URL to make sense of the error.