Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/txpool: fix error logs flood caused by removeAuthorities #31249

Merged
merged 3 commits into from
Feb 27, 2025
Merged

core/txpool: fix error logs flood caused by removeAuthorities #31249

merged 3 commits into from
Feb 27, 2025
+58 −5

Conversation

buddh0
Copy link
Contributor

@buddh0 buddh0 commented Feb 25, 2025 •
edited
Loading

when remove an non-SetCodeTxType transaction, error logs flood

t=2025-02-25T03:11:06+0000 lvl=error msg="Authority with untracked tx" addr=0xD5bf9221fCB1C31Cd1EE477a60c148d40dD63DC1 hash=0x626fdf205a5b1619deb2f9e51fed567353f80acbd522265b455daa0821c571d9
t=2025-02-25T03:11:06+0000 lvl=error msg="Authority with untracked tx" addr=0xc5098ce789965A19A17987e02b0F789E65A21F16 hash=0x626fdf205a5b1619deb2f9e51fed567353f80acbd522265b455daa0821c571d9
t=2025-02-25T03:11:06+0000 lvl=error msg="Authority with untracked tx" addr=0x563D4ADD8461dA7B617e0da08Bb096A0971DF49e hash=0x626fdf205a5b1619deb2f9e51fed567353f80acbd522265b455daa0821c571d9
t=2025-02-25T03:11:06+0000 lvl=error msg="Authority with untracked tx" addr=0xD5bf9221fCB1C31Cd1EE477a60c148d40dD63DC1 hash=0xe2cb74e63fec1d7a4ffc9fe3a39a1dc8a8fca4c752bb70037c24d286572967f9
t=2025-02-25T03:11:06+0000 lvl=error msg="Authority with untracked tx" addr=0xc5098ce789965A19A17987e02b0F789E65A21F16 hash=0xe2cb74e63fec1d7a4ffc9fe3a39a1dc8a8fca4c752bb70037c24d286572967f9
t=2025-02-25T03:11:06+0000 lvl=error msg="Authority with untracked tx" addr=0x563D4ADD8461dA7B617e0da08Bb096A0971DF49e hash=0xe2cb74e63fec1d7a4ffc9fe3a39a1dc8a8fca4c752bb70037c24d286572967f9

in this PR, only try to removeAuthorities for txs with SetCodeTxType

in addition, the performance of removeAuthorities improved a lot,
because no need range all t.auths now.

@buddh0 buddh0 force-pushed the only_removeAuthorities_SetCodeTxType branch from 8692589 to 77b28a0 Compare February 25, 2025 08:15
@buddh0 buddh0 changed the title core/txpool: only removeAuthorities for SetCodeTxType txs core/txpool: fix error logs flood caused by removeAuthorities Feb 25, 2025
@buddh0 buddh0 marked this pull request as ready for review February 25, 2025 08:18
@buddh0 buddh0 mentioned this pull request Feb 25, 2025
Closed
@fjl
Copy link
Contributor

fjl commented Feb 26, 2025

@lightclient has also created his own PR to fix this: #31263

@fjl fjl mentioned this pull request Feb 26, 2025
Closed
@lightclient lightclient force-pushed the only_removeAuthorities_SetCodeTxType branch from ad1d4e3 to 1212781 Compare February 26, 2025 16:59
@lightclient
Copy link
Member

Thanks @buddh0. I made a few small adjustments and added some additional testing.

@rjl493456442 rjl493456442 added this to the 1.15.4 milestone Feb 27, 2025
@buddh0
Copy link
Contributor Author

buddh0 commented Feb 27, 2025

Thanks @buddh0. I made a few small adjustments and added some additional testing.

LGTM,thx

@rjl493456442 rjl493456442 merged commit fc4dd18 into ethereum:master Feb 27, 2025
4 checks passed
@buddh0 buddh0 deleted the only_removeAuthorities_SetCodeTxType branch February 28, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@lightclient lightclient lightclient approved these changes

@NathanBSC NathanBSC NathanBSC approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees

@lightclient lightclient

Labels
None yet
Projects
None yet
Milestone
1.15.4
Development

Successfully merging this pull request may close these issues.
5 participants
@buddh0 @fjl @lightclient @rjl493456442 @NathanBSC