build: simplify go mod tidy check #31266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can just use the that would much better. |
|
I agree it's better to use One thing we can do, is fold the check into the generated files check. go.mod/go.sum are kind of like generated files anyway. |
build/ci.go
Outdated
| if updates := build.DiffHashes(hashes, tidied); len(updates) > 0 { | ||
| log.Fatalf("files changed on running 'go mod tidy': %v", updates) | ||
| } | ||
| build.MustRun(new(build.GoToolchain).Go("mod", "tidy", "-diff")) |
There was a problem hiding this comment.
The diff will be printed on the Stdout and Stderr, but the output is not checked?
There was a problem hiding this comment.
It exits with a non-zero code if the diff is not empty.
fjl
changed the title
fjl
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's simple and can print necessary information as well.
ref:
https://go.dev/ref/mod#go-mod-tidy:~:text=The%20%2Ddiff%20flag%20causes
https://go.dev/doc/go1.23#:~:text=The%20new%20go%20mod%20tidy%20%2Ddiff