Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutables with literal values are pure. #10240

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Immutables with literal values are pure. #10240

merged 1 commit into from
Nov 10, 2020

Conversation

chriseth
Copy link
Contributor

@chriseth chriseth commented Nov 9, 2020

Fixes #9554

@chriseth chriseth force-pushed the immutablesPureValue branch from a3a32ba to 9a77c39 Compare November 9, 2020 17:16
leonardoalt
leonardoalt previously approved these changes Nov 9, 2020
View reviewed changes
@leonardoalt
Copy link
Member

Needs rebase though

@chriseth chriseth force-pushed the immutablesPureValue branch from 9a77c39 to 765ed13 Compare November 10, 2020 12:08
@leonardoalt leonardoalt merged commit 55ac5de into develop Nov 10, 2020
@leonardoalt leonardoalt deleted the immutablesPureValue branch November 10, 2020 15:23
@chriseth chriseth mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardoalt leonardoalt leonardoalt approved these changes

@cameel cameel Awaiting requested review from cameel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

immutable state variables are not considered pure in inheritance
2 participants
@chriseth @leonardoalt