Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpt: simplify rangeProof handling & flatten mpt file structure #3740

Merged
merged 15 commits into from
Feb 24, 2025

Conversation

gabrocheleau
Copy link
Contributor

This addresses this comment and makes some misc minor improvemnts to the mpt package.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (cfc5309) to head (0025266).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 76.87% <ø> (ø)
blockchain 85.69% <ø> (ø)
client 66.27% <90.90%> (-0.02%) ⬇️
common 90.72% <ø> (ø)
devp2p 76.27% <ø> (ø)
ethash 81.04% <ø> (ø)
evm 71.06% <ø> (+0.01%) ⬆️
genesis 99.84% <ø> (ø)
mpt 59.72% <100.00%> (-0.41%) ⬇️
rlp 69.70% <ø> (ø)
statemanager 70.47% <100.00%> (ø)
tx 80.96% <ø> (ø)
util 85.54% <ø> (ø)
vm 57.81% <ø> (ø)
wallet 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: I liked the non-flattened version a bit more, would not make this a blocker though.

What is important (necessary) though: have these files been moved by git ? (GitHub then normally shows the transition) Otherwise we would loose git history for these files. So if not, this would need an update.

@gabrocheleau
Copy link
Contributor Author

For the record: I liked the non-flattened version a bit more, would not make this a blocker though.

What is important (necessary) though: have these files been moved by git ? (GitHub then normally shows the transition) Otherwise we would loose git history for these files. So if not, this would need an update.

I've decided to restore the initial folder structure, and only do the other updates (refactoring of the rangeProof etc.)

@holgerd77
Copy link
Member

Client tests not going through

@gabrocheleau
Copy link
Contributor Author

Client tests not going through

fixed by re-running

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrocheleau gabrocheleau merged commit bd77a74 into master Feb 24, 2025
41 checks passed
@scorbajio scorbajio deleted the mpt/additional-minor-fixes branch February 24, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants