Fixed Race Condition #453 #30
Conversation
Fixed how it is doing the this._getDBs and this.putDBs
There was a problem hiding this comment.
Gived a look about the PR and compared to this PR :
https://github.com/ethereumjs/merkle-patricia-tree/pull/28/files
which is similar. This current PR has a single line of difference for which i'm asking myself of potential typo.
Sorry if i'm wrong. Anyway, solid knowledge from devs to handle that kind of stuff.
Much #datalove
| this.__putDBs = this._putDBs | ||
| this._putDBs = [this._scratch] | ||
| this._putDBs = [this._scratch].concat(this._getDBs) |
There was a problem hiding this comment.
don't know much about the code around this, but 've been reading the the related issues that led to this PR ( originally reading from the race conditions issue opened in ganache-cli repo ).
as _putDBs and _getDBs seems to be different objects, is op ( @kammerdiener ) sure that this is not a typo ?
Was this._putDBs = [this._scratch].concat(this._putDBs); intended instead ?
( sorry if it is not, just trying to educate myself ^^" )
|
Sorry, this was left aside a bit. Will have a look in the upcoming days (maybe next week). |
|
Thanks for the PR! Since there was a fix on this submitted earlier and also having a cleaner commit history, I will close here. |
Fixed how it is doing the this._getDBs and this._putDBs
PR #28 fixes the this._getDBs issue and this has the same fix.