Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sed validation #14

Merged
merged 1 commit into from
Jan 24, 2018
Merged

sed validation #14

merged 1 commit into from
Jan 24, 2018

Conversation

hugo-dc
Copy link
Contributor

@hugo-dc hugo-dc commented Dec 28, 2017

Make sure sed have at least 1 match, if the string is not found then stop and show error. Fixes #12

@hugo-dc hugo-dc mentioned this pull request Dec 28, 2017
Closed
axic
axic approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the two commits before merging.

axic
axic requested changes Jan 5, 2018
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and squash (since #11 was merged).

@hugo-dc
Copy link
Contributor Author

hugo-dc commented Jan 24, 2018

rebased and squashed, please let me know if any other change is needed

@axic axic merged commit 8865629 into ethereumjs:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugo-dc @axic