-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my part this is now ok. But I am not at all sure whether the idea I have of "healthiness" is the right one anymore. So I defer judgement. My advice is to have two more approvals of this besides mine from someone who understands the terms that are in use.
I had a discussion with @holisticode about this. IMHO healthy is primarily used as a stop condition in simulation tests |
obsoleted by #1195 |
This PR adds the parameter
Robust
to theHealthy
structure.Robust
denoteswhether we are connected to a minimum of peers in all the bins we have known peers in
.It is meant as a discussion PR until we reach consensus on how this parameter will be used.
For reviewers other than @nolash :
You are welcome to leave comments but this is not yet ready for formal review.