HA-415 - Adding new data_types: time, date and datetime #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erosselli
reviewed
Jan 30, 2025
Comment on lines
+703
to
+704
| @pytest.mark.parametrize("data_type", ["not_string", "not_integer", "not_float", "not_boolean", "not_object", "not_time", "not_date", "not_datetime"]) | ||
| def test_invalid_types(self, data_type): |
There was a problem hiding this comment.
we don't seem to be using the data_type argument in this test, unless I'm missing something?
|
Not longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HA-415
Description Of Changes
Add new data_types: time, date and datetime
Code Changes
Steps to Confirm
nox -s pytestPre-Merge Checklist
CHANGELOG.md