HA-399 deprecate cookies #27
Conversation
There was a problem hiding this comment.
my expectation was that we'd actually remove and ignore cookies being specified on these models. ideally we wouldn't cause validation errors, but we'd provide warnings (as you're doing) and then actually ignore the cookies values.
as part of that, i'd fully remove the Cookies model class.
does that makes sense?
There was a problem hiding this comment.
nice, looks solid @kirk!
i do think it'd be good to test how this actually integrates/manifests with application use, i.e. within fides. you should be able to do that by pinning the fideslang dep in fides' requirements.txt to a git commit. you could also manually push an alpha tag to this fideslang branch and that'll get you a prerelease packge of fideslang on pypi that you can reference from requirements.txt of fides
| @@ -8,6 +8,7 @@ | |||
| from datetime import datetime | |||
| from enum import Enum | |||
| from typing import Annotated, Dict, List, Optional, Union, Any | |||
| from warnings import warn | |||
There was a problem hiding this comment.
hmm, how does this work? have we tested how this actually manifests in application use?
i don't think we use this builtin anywhere else, so it'd just be good to verify that it surfaces in the way you'd want/expect.
i think the two things to test would be specifying a cookies attribute on an API call to the /systems endpoint, and using the CLI to push/pull a system definition with cookies
Part of HA-399
Description Of Changes
Add validators to the
Cookiesmodel and each model that uses a.cookiesproperty warning of deprecationCode Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md