You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The identifiers for options.define should be replaced before injecting modules in options.inject
Another way to put this: define identifiers should have higher priority than exports in inject
This would prevent many injections from running, for example replacing occurrences of process.env.VAR with define could skip the injection of a ./process.js module
Currently the injections are run first, which also means that the identifiers in define are never used if they are properties of an object exported from a module in inject
The identifiers for
options.define
should be replaced before injecting modules inoptions.inject
Another way to put this:
define
identifiers should have higher priority than exports ininject
This would prevent many injections from running, for example replacing occurrences of
process.env.VAR
with define could skip the injection of a./process.js
moduleCurrently the injections are run first, which also means that the identifiers in
define
are never used if they are properties of an object exported from a module ininject
Reproduction: https://github.com/remorses/esbuild-inject-overrides-defines
The text was updated successfully, but these errors were encountered: