Apply defines before injected global variables #1261
Conversation
| @@ -9508,8 +9508,10 @@ func (p *parser) isDotDefineMatch(expr js_ast.Expr, parts []string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // The last symbol must be unbound | |||
| return p.symbols[result.ref.InnerIndex].Kind == js_ast.SymbolUnbound | |||
| p.ignoreUsage(result.ref) | |||
There was a problem hiding this comment.
If we replace an injected symbol with a define, we need to explicitly mark it as unused (as p.findSymbol has the effect of marking usage). Otherwise, the injected import won't be eliminated.
Calling p.ignoreUsage feels a bit hacky. I also suppose that ignoreUsage should be invoked closer to the actual replacement callsite rather than in isDotDefineMatch, which doesn't necessitate that a replacement actually occurs...
rtsao
force-pushed
the
define-before-inject
branch
from
e5d626c to
dfb36d4
Compare
|
I agree that #660 would be good to solve. However, it seems like a breaking change to me in that this may cause subtle and unintentional behavior changes. So I'd like to wait on this until the next round of breaking changes (i.e. the next minor version bump, since esbuild is <1.0.0). |
|
Thanks! I appreciate you taking the time to fix this. |
Resolves #660
This seemed like the most straightforward way of addressing this, would love feedback