Log external req ip and host #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanneary
force-pushed
the
hannah/etr-2883-add-egress-request-logging-to-control-plane
branch
from
ae2ef06 to
1a471ff
Compare
ghost
approved these changes
Jan 3, 2025
hanneary
deleted the
hannah/etr-2883-add-egress-request-logging-to-control-plane
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Debugging egress networking currently involves using VPC flow logs. Logging the ip and hostname in the control plane will expose this info for easier debugging by users.
How
Log the host and ip when external connections are being created