This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Fix CALLs #264
Merged
Fix CALLs #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commits regarding the "2300 call stipend" can be removed if ewasm/hera#219 is merged. |
axic
force-pushed
the
callcall2
branch
3 times, most recently
from
31cc133 to
d753b23
Compare
|
This passes with ewasm/hera#219. |
axic
commented
May 28, 2018
wasm/generateInterface.js
Outdated
| @@ -281,7 +338,7 @@ function generateManifest (interfaceManifest, opts) { | |||
| (i64.store (i32.add (get_global $sp) (i32.const ${spOffset * 32 + 8 * 2})) (i64.const 0))` | |||
|
|
|||
| if (!op.async) { | |||
| call += '(drop (call $bswap_m128 (i32.add (i32.const 32)(get_global $sp))))' | |||
| call += '(drop (i32.add (i32.const 32)(get_global $sp)))' | |||
There was a problem hiding this comment.
This line is useless, it is a no-op.
In the previous case bswap_m128 operates on memory, so it wasn't a no-op.
axic
commented
May 28, 2018
wasm/generateInterface.js
Outdated
| @@ -292,7 +349,7 @@ function generateManifest (interfaceManifest, opts) { | |||
| } | |||
|
|
|||
| call += `) | |||
| (drop (call $bswap_m160 (i32.add (get_global $sp) (i32.const ${spOffset * 32})))) | |||
| (drop (i32.add (get_global $sp) (i32.const ${spOffset * 32}))) | |||
axic
commented
May 28, 2018
| // add 2300 gas subsidy | ||
| // for now this only works if the gas is a 64-bit value | ||
| // TODO: use 256-bit arithmetic | ||
| /* |
There was a problem hiding this comment.
Why is this kept as a comment?
There was a problem hiding this comment.
it will be relevant when we simplify the EEI and move the ugly gas logic here into evm2wasm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246 (replaces).