Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheritable notification methods #514

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

excid3
Copy link
Owner

@excid3 excid3 commented Dec 16, 2024

When inheriting Notifiers, the Notification class will also inherit from it's parent's Notification class.

Discussion #509

@excid3 excid3 added the enhancement New feature or request label Dec 16, 2024
@excid3 excid3 force-pushed the inheritable-notification-methods branch from c602928 to e6fc44a Compare December 16, 2024 22:18
@excid3
Copy link
Owner Author

excid3 commented Dec 16, 2024

@wdiechmann this should add the inheritance we were talking about in #509 👍

@excid3 excid3 force-pushed the inheritable-notification-methods branch from e6fc44a to 4093ebd Compare December 16, 2024 22:21
@wdiechmann
Copy link

Christmas did indeed come early this year 🎄

huge thx @excid3 😍

(and with such elegance if I may say so)

@excid3 excid3 merged commit 0e49323 into main Dec 17, 2024
30 checks passed
@excid3 excid3 deleted the inheritable-notification-methods branch December 17, 2024 15:02
@excid3
Copy link
Owner Author

excid3 commented Dec 17, 2024

Released in 2.5.0

@wdiechmann
Copy link

Updated and deploy'ed to production with warm thanks and best wishes for your seasons holidays and a productive/joyful New Year 😍

@excid3
Copy link
Owner Author

excid3 commented Dec 20, 2024

@wdiechmann you too! 🎄 🎅 🤶 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants