🐛 FIX: Convert empty directive option to None (#452)

This allows for converters like `optional_int` to work correctly
executablebooks · Dec 4, 2021 · ea6e967 · ea6e967
1 parent 89ad170
commit ea6e967
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/myst_parser/parse_directives.py b/myst_parser/parse_directives.py
@@ -147,7 +147,7 @@ def parse_directive_options(
             raise DirectiveParsingError(f"Unknown option: {name}")
         if not isinstance(value, str):
             if value is True or value is None:
-                value = ""  # flag converter requires no argument
+                value = None  # flag converter requires no argument
             elif isinstance(value, (int, float, datetime.date, datetime.datetime)):
                 # convertor always requires string input
                 value = str(value)

diff --git a/tests/test_renderers/fixtures/sphinx_directives.md b/tests/test_renderers/fixtures/sphinx_directives.md
@@ -45,8 +45,9 @@ highlight (`sphinx.directives.code.Highlight`):
 code-block (`sphinx.directives.code.CodeBlock`):
 .
 ```{code-block}
+:dedent:
 
-a=1
+    a=1
 ```
 .
 <document source="notset">