Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Exercise] Ledger #2398

Merged
merged 5 commits into from
Mar 23, 2024
Merged

[New Exercise] Ledger #2398

merged 5 commits into from
Mar 23, 2024

Conversation

Cool-Katt
Copy link
Contributor

Do tell if you think that the example file needs more work to make it even more bad. I tried to keep it reasonable.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 9, 2024
@SleeplessByte SleeplessByte reopened this Feb 9, 2024
@Cool-Katt
Copy link
Contributor Author

And again, bump here.
I would be happy to get this merged so let me know if I need to do anything else.

@SleeplessByte SleeplessByte self-requested a review February 29, 2024 16:53
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love to hate it <3

@Cool-Katt
Copy link
Contributor Author

@SleeplessByte
I know it doesn't make a difference for the actual exercise, but I updated the proof.ci.js based on what you suggested.
I'm not sure it's cleaner but it looks more uniform at least.

@Cool-Katt Cool-Katt requested a review from SleeplessByte March 23, 2024 10:10
@SleeplessByte
Copy link
Member

Oh yeah it's just a proof but I do like it better like this 😁

@SleeplessByte SleeplessByte merged commit 0c91c84 into exercism:main Mar 23, 2024
7 checks passed
@Cool-Katt Cool-Katt deleted the ledger branch March 23, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants