Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Commit

Permalink
fix(backends): fix secretsManager backend name (#27)
Browse files Browse the repository at this point in the history
  • Loading branch information
JacopoDaeli authored Mar 9, 2019
1 parent 422b7ff commit d494edf
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ kind: ExternalSecret
metadata:
name: hello-service
secretDescriptor:
backendType: secretManager
backendType: secretsManager
properties:
- key: hello-service/password
name: password
Expand Down Expand Up @@ -107,7 +107,7 @@ kind: ExternalSecret
metadata:
name: hello-service
secretDescriptor:
backendType: secretManager
backendType: secretsManager
properties:
- key: hello-service/credentials
name: password
Expand Down
9 changes: 6 additions & 3 deletions config/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,18 @@ const customResourceManager = new CustomResourceManager({
logger
});

const secretManagerClient = new AWS.SecretsManager({ region: envConfig.awsRegion });
const secretManagerBackend = new SecretsManagerBackend({ client: secretManagerClient, logger });
const secretsManagerClient = new AWS.SecretsManager({ region: envConfig.awsRegion });
const secretsManagerBackend = new SecretsManagerBackend({ client: secretsManagerClient, logger });
const systemManagerClient = new AWS.SSM({ region: envConfig.awsRegion });
const systemManagerBackend = new SystemManagerBackend({ client: systemManagerClient, logger });
const backends = {
secretManager: secretManagerBackend,
secretsManager: secretsManagerBackend,
systemManager: systemManagerBackend
};

// backwards compatibility
backends.secretManager = secretsManagerBackend;

module.exports = {
backends,
customResourceManager,
Expand Down
2 changes: 1 addition & 1 deletion examples/hello-service-external-secret.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: ExternalSecret
metadata:
name: hello-service
secretDescriptor:
backendType: secretManager
backendType: secretsManager
properties:
- key: hello-service/password
name: password

0 comments on commit d494edf

Please sign in to comment.