fix(secret): fix SSM parameter store code

external-secrets · Jul 17, 2019 · e5e635f · e5e635f
1 parent 93f01a4
commit e5e635f
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -93,6 +93,12 @@ Add your secret data to your backend. For example, AWS Secrets Manager:
 aws secretsmanager create-secret --name hello-service/password --secret-string "1234"
 ```
 
+AWS Parameter Store:
+
+```
+aws ssm put-parameter --name "/hello-service/password" --type "String" --value "1234"
+```
+
 and then create a `hello-service-external-secret.yml` file:
 
 ```yml
@@ -106,6 +112,18 @@ secretDescriptor:
     - key: hello-service/password
       name: password
 ```
+or
+```yml
+apiVersion: 'kubernetes-client.io/v1'
+kind: ExternalSecret
+metadata:
+  name: hello-service
+secretDescriptor:
+  backendType: systemManager
+  data:
+    - key: /hello-service/password
+      name: password
+```
 
 Save the file and run:
 

diff --git a/examples/awssm-key-value-example.yaml → examples/secretsmanager-example.yaml b/examples/awssm-key-value-example.yaml → examples/secretsmanager-example.yaml
diff --git a/examples/ssm-example.yaml b/examples/ssm-example.yaml
@@ -0,0 +1,9 @@
+apiVersion: 'kubernetes-client.io/v1'
+kind: ExternalSecret
+metadata:
+  name: ssm-secret-key
+secretDescriptor:
+  backendType: systemManager
+  data:
+    - key: /path/variable-name
+      name: variable-name
diff --git a/lib/backends/system-manager-backend.js b/lib/backends/system-manager-backend.js
@@ -26,7 +26,7 @@ class SystemManagerBackend extends KVBackend {
         WithDecryption: true
       })
       .promise()
-    return data.Value
+    return data.Parameter.Value
   }
 }
 

diff --git a/lib/backends/system-manager-backend.test.js b/lib/backends/system-manager-backend.test.js
@@ -29,7 +29,9 @@ describe('SystemManagerBackend', () => {
 
     it('returns secret property value', async () => {
       getParameterPromise.promise.resolves({
-        Value: 'fakeSecretPropertyValue'
+        Parameter: {
+          Value: 'fakeSecretPropertyValue'
+        }
       })
 
       const secretPropertyValue = await systemManagerBackend._get({