Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old nocache md5 #417

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Conversation

merwok
Copy link
Contributor

@merwok merwok commented Jan 10, 2025

Describe your changes

Remove more nocache/v params in favor of the smarter template tag

Related issue
Issue #384
PR #385
commit 36c7f5b

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@merwok
Copy link
Contributor Author

merwok commented Jan 10, 2025

Hello! I haven’t tested the changes in my project yet but will do today as soon as I can.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (b975844) to head (1abdf72).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          38       38           
  Lines         422      422           
=======================================
  Hits          411      411           
  Misses         11       11           
Flag Coverage Δ
unittests 97.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocaccamo
Copy link
Owner

@merwok thank you very much for this PR!

@fabiocaccamo fabiocaccamo merged commit 309da1a into fabiocaccamo:main Jan 11, 2025
35 checks passed
@merwok merwok deleted the fix-old-nocache-md5 branch January 11, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants