Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap scripts into dom loaded event listener if defer is specified #10753

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions packages/react-dev-utils/InlineChunkHtmlPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,22 @@ class InlineChunkHtmlPlugin {
}

compiler.hooks.compilation.tap('InlineChunkHtmlPlugin', compilation => {
const tagFunction = tag =>
this.getInlinedTag(publicPath, compilation.assets, tag);

const hooks = this.htmlWebpackPlugin.getHooks(compilation);
hooks.alterAssetTagGroups.tap('InlineChunkHtmlPlugin', assets => {
assets.headTags = assets.headTags.map(tagFunction);
assets.bodyTags = assets.bodyTags.map(tagFunction);
const deferScripts = [];
const tagFunction = tag => {
const result = this.getInlinedTag(publicPath, compilation.assets, tag);

if (result === tag || tag.tagName !== 'script' || !(tag.attributes && tag.attributes.defer)) {
return result;
}

deferScripts.push(result);
return undefined;
}

assets.headTags = assets.headTags.map(tagFunction).filter(Boolean);
assets.bodyTags = assets.bodyTags.map(tagFunction).filter(Boolean).concat(deferScripts);
});

// Still emit the runtime chunk for users who do not use our generated
Expand Down