Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatWebpackMessages.js (to re-add missing filename to error message) #12712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CarlRibbegaardh
Copy link

@CarlRibbegaardh CarlRibbegaardh commented Sep 6, 2022

This PR simply prints out the filename as the first line:

  } else if ('message' in message) {
    lines = message['message'].split('\n');
    if('file' in message){
      lines.unshift(message['file']);
    }

...which seems expected by row 77

  // Clean up file name
  lines[0] = lines[0].replace(/^(.*) \d+:\d+-\d+$/, '$1');

I use it normally as a local adjustment to my node_modules folder...

image

Solves this issue: #12365

@CarlRibbegaardh
Copy link
Author

@mrmckeb Any chance of a review?

@raDiesle
Copy link

@CarlRibbegaardh does the linting issue must be fixed first before review ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants