Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace concurrently with npm-run-all #7444

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

concurrently pulls in date-fns which is a lot of bloat. The entire dep tree of concurrently is 50MB, compared to npm-run-all's 10MB.

We'll also need to eventually get rid of rxjs in our node_modules. wait-on depends on it, but I believe it's unnecessary. We only have very lightweight usage of wait-on.

This is part of a bigger effort to migrate our building pipeline to something more light-weight while more robust. We'll use run-p extensively for watch, so that CSS editing can be hot-reloaded.

Test Plan

Tested locally by running yarn watch. Hot reloading works.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 18, 2022
@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners May 18, 2022 10:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022

[V2]

Name Link
🔨 Latest commit ce6a513
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6284c6442a86ec0009127ca2
😎 Deploy Preview https://deploy-preview-7444--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 49 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 78 🟢 99 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: 0 B

Total Size: 796 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.3 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 599 kB
website/build/index.html 38.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 5c3d3cf into main May 18, 2022
@Josh-Cena Josh-Cena deleted the jc/replace-concurrently branch May 18, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants