Dependeny on fmt not mentioned in installation instructions #1262
Comments
|
In particular, if In file included from /folly/folly/logging/LogStreamProcessor.cpp:17:0:
/folly/folly/logging/LogStreamProcessor.h:19:10: fatal error: fmt/core.h: No such file or directory |
|
I'll update the instructions. |
|
Oh, I see it's already done in #1263. Thanks, @SashaNullptr. |
facebook-github-bot
pushed a commit
that referenced
this issue
Nov 20, 2019
Summary: Dovetailing off of #1262 ; Folly's dependency on `fmt` isn't explicitly mentioned nor are from-source install instructions provided. This PR adds a short section to the README describing how to build and install fmt from source. Pull Request resolved: #1263 Reviewed By: vitaut Differential Revision: D18622693 Pulled By: yfeldblum fbshipit-source-id: e43ab8c5524df9decc79cdd0cb2aea3d88826617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fmt not mentioned as dependency
Folly depends on the fmt library in order to build, as seen in folly-deps.cmake as of da41ae5 . This isn't mentioned in the installation instructions. For example if one is naively following the Ubuntu 16.04 LTS install instructions CMake will fail to find
fmtand error out.On Ubuntu 18.04 LTS installing
libfmt-devdoesn't fix things, at least not with CMake running without any flags (i.e.cmake ..). It seems that fmt needs to be installed from source as described in the fmt usage guide.The text was updated successfully, but these errors were encountered: