Do not destroy views when there is a touch going on for New Architecture #45865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60594878 |
|
This pull request was exported from Phabricator. Differential Revision: D60594878 |
cortinico
force-pushed
the
export-D60594878
branch
from
9327fd0 to
4fa44e8
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 7, 2024
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
|
This pull request was exported from Phabricator. Differential Revision: D60594878 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 7, 2024
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Differential Revision: D60594878
cortinico
force-pushed
the
export-D60594878
branch
from
4fa44e8 to
9b48bd3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60594878 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 8, 2024
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Reviewed By: mdvacca Differential Revision: D60594878
cortinico
force-pushed
the
export-D60594878
branch
from
9b48bd3 to
1bbf5a4
Compare
…ure (facebook#45865) Summary: Pull Request resolved: facebook#45865 This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the `JSTouchDispatcher` and eventually defer the view deletion till the view is not interacted anymore. The JSTouchDispatcher already retains the information on which tag was the touch originally fired. We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted. This is causing a couple of bad bugs on Android: Fixes facebook#45126 Fixes facebook#44610 Closes facebook#45675 Changelog: [Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture Reviewed By: mdvacca Differential Revision: D60594878
|
This pull request was exported from Phabricator. Differential Revision: D60594878 |
cortinico
force-pushed
the
export-D60594878
branch
from
1bbf5a4 to
de3cad1
Compare
|
This pull request has been merged in 6b7f682. |
|
This pull request was successfully merged by @cortinico in 6b7f682 When will my fix make it into a release? | How to file a pick request? |
|
@cortinico Hello, We have also encountered this kind of problem. Many users reported that the page stopped responding when using it. Since we are using version 0.74.1 and the user base is very large, we cannot upgrade to version 0.76 quickly。would you like to ask if this fix fixes some of the following related issues: |
This was referenced Dec 25, 2024
@peaktan I'm not entirely sure as those issues you linked are really broad, and users reported problems coming from other libraries (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduces the logic to defer the destruction of ViewState (and EventEmitter) for views that are currently touched on by the user. The idea is to let the UIManager know which view is currently active from the
JSTouchDispatcherand eventually defer the view deletion till the view is not interacted anymore.The JSTouchDispatcher already retains the information on which tag was the touch originally fired.
We'll pass over that information to the UIManager/SurfaceMountingManager so that it can be accounted for when the view has to be deleted.
This is causing a couple of bad bugs on Android:
Fixes #45126
Fixes #44610
Closes #45675
Changelog:
[Android] [Fixed] - Do not destroy views when there is a touch going on for New Architecture
Differential Revision: D60594878