Add Example of usge in HelloWorld app #49610
Open
+343
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This Change introduces a new pod that can be imported by a Swift App Delegate. This pod contains basic classes that allow the creation of pure C++ TM (with a very smal bridge of Objective-C++) that can be registered in a Swift App delegate. ## Problem As of today, it is not possible to create a pure C++ TM and to register it through a Swift AppDelegate ## Solution We can create a pod that can be imported in a Swift AppDelegate and that offer some pure Objective-C classes. These classes contains a provider that can be instantiated in Swift. The TurboModule manager delegate will ask the AppDelegate about the presence of some provider that can instantiate a pure C++ turbomodule with a given name. The provider has an empty interface, but the implementation contains a function that can actually instantiate the TM. The function is implemented in an Objective-C++ class that imports the pure C++ turbomodule and creates it. The TMManager extends the provider through a category to attaach the signature of the function that is implemented by the provider. The last diff in this stack contains an exaple on how to implement this. ## Changelog: [iOS][Added] - Added the React-SwiftCompatibleNativeModules pod Differential Revision: D69999280
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70012738 |
…acebook#49611) Summary: Pull Request resolved: facebook#49611 This Change connects the pod created previously to the `RCTTuboModuleManager` so that it can ask the delegate about the CxxTurboModuleProviders. We had to introduce a `RCTFullTurboModuleManagerDelegate` that implements both the old `TurboModuleManagerDelegate` and the new Swift compatible one. ## Problem As of today, it is not possible to create a pure C++ TM and to register it through a Swift AppDelegate ## Solution We can create a pod that can be imported in a Swift AppDelegate and that offer some pure Objective-C classes. These classes contains a provider that can be instantiated in Swift. The TurboModule manager delegate will ask the AppDelegate about the presence of some provider that can instantiate a pure C++ turbomodule with a given name. The provider has an empty interface, but the implementation contains a function that can actually instantiate the TM. The function is implemented in an Objective-C++ class that imports the pure C++ turbomodule and creates it. The TMManager extends the provider through a category to attaach the signature of the function that is implemented by the provider. The last diff in this stack contains an exaple on how to implement this. ## Changelog: [iOS][Added] - Added the React-SwiftCompatibleNativeModules pod Differential Revision: D70012142
Summary: This change propagates the delegate chain calls up until the `RCTReactNativeFactoryDelegate`. ## Problem As of today, it is not possible to create a pure C++ TM and to register it through a Swift AppDelegate ## Solution We can create a pod that can be imported in a Swift AppDelegate and that offer some pure Objective-C classes. These classes contains a provider that can be instantiated in Swift. The TurboModule manager delegate will ask the AppDelegate about the presence of some provider that can instantiate a pure C++ turbomodule with a given name. The provider has an empty interface, but the implementation contains a function that can actually instantiate the TM. The function is implemented in an Objective-C++ class that imports the pure C++ turbomodule and creates it. The TMManager extends the provider through a category to attaach the signature of the function that is implemented by the provider. The last diff in this stack contains an exaple on how to implement this. ## Changelog: [iOS][Added] - Added the delegate calls to forward the request for the CxxTurboModuleProvider from the Manager to the ReactNativeFactory Differential Revision: D70012290
Summary: Pull Request resolved: facebook#49610 donotcommit This change is an example of usage of how an App can register a pure C++ TM through this mechanism. It basically implements the guide [here](https://reactnative.dev/docs/next/the-new-architecture/pure-cxx-modules), adding a couple of steps: - The implementation of the CxxTurboModuleProvider - The creation of a bridging header file It also show how to register the module in the Swift AppDelegate ## Problem As of today, it is not possible to create a pure C++ TM and to register it through a Swift AppDelegate ## Solution We can create a pod that can be imported in a Swift AppDelegate and that offer some pure Objective-C classes. These classes contains a provider that can be instantiated in Swift. The TurboModule manager delegate will ask the AppDelegate about the presence of some provider that can instantiate a pure C++ turbomodule with a given name. The provider has an empty interface, but the implementation contains a function that can actually instantiate the TM. The function is implemented in an Objective-C++ class that imports the pure C++ turbomodule and creates it. The TMManager extends the provider through a category to attaach the signature of the function that is implemented by the provider. The last diff in this stack contains an exaple on how to implement this. ## Changelog: [iOS][Added] - Added the React-SwiftCompatibleNativeModules pod Differential Revision: D70012738
|
This pull request was exported from Phabricator. Differential Revision: D70012738 |
cipolleschi
force-pushed
the
export-D70012738
branch
from
e604de7 to
74133d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
donotcommit
This change is an example of usage of how an App can register a pure C++ TM through this mechanism.
It basically implements the guide here, adding a couple of steps:
It also show how to register the module in the Swift AppDelegate
Problem
As of today, it is not possible to create a pure C++ TM and to register it through a Swift AppDelegate
Solution
We can create a pod that can be imported in a Swift AppDelegate and that offer some pure Objective-C classes.
These classes contains a provider that can be instantiated in Swift.
The TurboModule manager delegate will ask the AppDelegate about the presence of some provider that can instantiate a pure C++ turbomodule with a given name.
The provider has an empty interface, but the implementation contains a function that can actually instantiate the TM. The function is implemented in an Objective-C++ class that imports the pure C++ turbomodule and creates it.
The TMManager extends the provider through a category to attaach the signature of the function that is implemented by the provider.
The last diff in this stack contains an exaple on how to implement this.
Changelog:
[iOS][Added] - Added the React-SwiftCompatibleNativeModules pod
Differential Revision: D70012738