Remove allow transparency #10823
Remove allow transparency #10823
Conversation
| | `as=(string 'true')`| (changed)| `"true"` | | ||
| | `as=(string 'false')`| (changed)| `"false"` | | ||
| | `as=(string 'on')`| (changed)| `"on"` | | ||
| | `as=(string 'off')`| (changed)| `"off"` | |
There was a problem hiding this comment.
Why did these change? Was it just outdated or something?
There was a problem hiding this comment.
Huh. Good question. I don't know. I made this file by exporting it from the browser. I'll see what's up.
There was a problem hiding this comment.
Maybe you're not using latest Chrome? I recently updated those (see blame).
|
Trying to re-record, but I'm hitting this locally:
I'm not really sure where unpkg is even referenced. Any ideas? Otherwise I could just revert that section by hand. |
|
We need to update
etc |
nhunzaker
force-pushed
the
remove-allow-transparency
branch
from
480d5a8 to
f1afa04
Compare
|
@gaearon Thanks. Now I'm questioning my grep technique 😨. I've updated the URLS and the snapshot. |
|
Why is CI failing? 😥 |
|
I rebased and force pushed my branch. Maybe it threw off CI. |
`allowtransparency` is an Internet Explorer-only attribute that controls the background transparency of an iFrame. When set to true, it respects the background color of the iFrame. When set to false, it sets the background color to that of the document. This feature was removed in IE9 - falling out of React's support commitment. Developers that have somehow figured out how to get IE8 to work with React 16.x can still use `allowtransparency="true"`, since React now supports unrecognized attributes.
nhunzaker
force-pushed
the
remove-allow-transparency
branch
from
f1afa04 to
f938640
Compare
|
Neat. An empty commit did the trick! CI passes! |
|
Was this change included in the v16.1 release notes? |
|
Probably forgot it, no. Happy to take changelog PR. |
|
I'll take the blame :). @ljharb So I better understand the ramifications of this change, our understanding was that this was =< IE8. Did this cause any functional changes on your end? |
|
@nhunzaker it caused jsx-eslint/eslint-plugin-react#1538 to be filed, is all. |
allowtransparencyis an Internet Explorer-only attribute that controls the background transparency of an iFrame. When set to true, it respects the background color of the iFrame. When set to false, it sets the background color to that of the document.This feature was removed in IE9. Browsers beyond this point just let you set the background of the document body to transparent, making the attribute unnecessary.
Should some ambitious/poor developer manage to get IE7/8 to work with React 16.x, they can still use
allowtransparency="true", since React now supports unrecognized attributes.How I verified this change
Check out the MSDN Example on allowTransparency
IE8 looks like this:
Every other browser: