[compiler] Add support for BigIntLiteral #32305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inottn
commented
Feb 5, 2025
Comment on lines
346
to
+350
| result = {kind: 'Primitive', value: lhs + rhs, loc: value.loc}; | ||
| } else if (typeof lhs === 'string' && typeof rhs === 'string') { | ||
| result = {kind: 'Primitive', value: lhs + rhs, loc: value.loc}; | ||
| } else if (typeof lhs === 'bigint' && typeof rhs === 'bigint') { | ||
| result = {kind: 'Primitive', value: lhs + rhs, loc: value.loc}; |
There was a problem hiding this comment.
This code appears to be somewhat redundant. For example, multiple if/else-if conditions could be combined, and the condition typeof lhs === 'number' && typeof rhs === 'number' could be moved to an outer layer. However, I'm not sure why this wasn't done before—perhaps it was intentional—so I've chosen to keep the original implementation.
Comment on lines
354
to
+358
| case '-': { | ||
| if (typeof lhs === 'number' && typeof rhs === 'number') { | ||
| result = {kind: 'Primitive', value: lhs - rhs, loc: value.loc}; | ||
| } else if (typeof lhs === 'bigint' && typeof rhs === 'bigint') { | ||
| result = {kind: 'Primitive', value: lhs - rhs, loc: value.loc}; |
There was a problem hiding this comment.
I did not apply this code to every operation. Specifically, I excluded operators such as *, **, and << because they might compute extremely large values, which could significantly increase the size of the compiled code.
|
++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The compiler currently doesn't support BigInt. As a primitive type in JS, I believe it can be implemented using existing Primitive kind.
However, in the AST obtained via Babel, the value of BigIntLiteral is also of string type. Therefore, a new field is needed to distinguish it from a actual string. I've temporarily named it isBigInt, as the name is quite intuitive.I realized that I can convert the value corresponding to BigIntLiteral to the bigint type directly, which would eliminate the need for a new field to identify it.
How did you test this change?
Added a test. I tried modifying the existing test cases, but the results looked messy, so I added new test cases instead.